Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41306: Add DDS package template #244

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

couger01
Copy link

@couger01 couger01 commented Mar 5, 2024

Add DDS package template for Telescope and Site Software team.

@couger01 couger01 marked this pull request as ready for review March 11, 2024 14:50
Copy link

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@timj timj changed the title Add DDS package template DM-41306: Add DDS package template Apr 5, 2024
@timj
Copy link
Member

timj commented Apr 5, 2024

What happened to this pull request? The Jira ticket is done so maybe this can be closed?

@couger01
Copy link
Author

couger01 commented Apr 5, 2024

Hi Tim, I made the PR and Wouter reviewed from our side. However I wasn't sure how to get attention on this PR, so if you or someone with access could review it for DM standards. That would be great. Thanks!

@timj
Copy link
Member

timj commented Apr 5, 2024

Ok. I think you need to reopen the Jira ticket then.

I was also wondering how this relates to project_templates/stack_package/example_dds that already exists.

@couger01
Copy link
Author

This is supposed to be a more up to date template that the TSSW team is using but I felt that it deviated too much from the old template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants