DM-11395: Update testdata_jointcal refcats to new Indexed format #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdswinbank
reviewed
Jan 31, 2019
|
|
||
| # Depth of the HTM tree to make. Default is depth=7 which gives | ||
| # ~ 0.3 sq. deg. per trixel. | ||
| config.indexer['HTM'].depth=7 |
There was a problem hiding this comment.
Same comment re default here as in Jointcal, and in other files in this package.
There was a problem hiding this comment.
I copied these files from validation_data_*, and I know nothing about why these choices were made.
There was a problem hiding this comment.
That's fine, but can we note that, rather than preserving the confusing comment, please?
There was a problem hiding this comment.
Does my update to the readme clarify things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.