DM-6623: make jointcal integration/validation test for cfht #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cfht_and_index | ||
| -------------- | ||
|
|
||
| Astrometry index catalogs corresponding to the twinkles1 data. |
There was a problem hiding this comment.
Is it for the twinkles1 data, or the cfht data? If the former, why is it in this commit? If the latter, then this line is wrong.
There was a problem hiding this comment.
Good catch. That was a typo.
|
Commit message: use imperative rather than past tense ("add" instead of "added"). |
|
Is two visits really sufficient for testing jointcal? |
|
Two visits is all I have from validation_data_cfht. It's enough to confirm that things work. More visits would be very nice for in depth testing, but I have 10 twinkles visits and 6 HSC visits in other tests, so I think the moderate-N visit tests are covered that way. |
Data was derived from validation_data_cfht, with extraneous files removed and the calexps zeroed out and gzipped via the included compress_jointcal_cfht_test_data.py file. Added the associated astrometry.net files. Generated a skymap and included it. Added notes to the readme.
parejkoj
force-pushed
the
tickets/DM-6623
branch
from
88325fa
to
940af6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data was derived from validation_data_cfht, with extraneous files removed and
the calexps zeroed out and gzipped via the included
compress_jointcal_cfht_test_data.py file.
Added the associated astrometry.net files.
Generated a skymap and included it.
Added notes to the readme.