Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-24320: Add parquet sourceTable_visit catalogs to hsc repo #27

Merged
merged 1 commit into from Jun 4, 2020

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Jun 1, 2020

No description provided.

# measurement. Finally, the default Source.yaml file needs to be modified to remove
# the sky_source column which did not exist for the w_2020_14 RC2 reprocessing

writeSourceTable.py ./hsc --output ./hsc --id filter=HSC-R^HSC-I --config doApplyExternalPhotoCalib=True --config doApplyExternalSkyWcs=True --no-versions
Copy link
Collaborator

@parejkoj parejkoj Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using doApplyExternal* here? The data in hsc/ does not have jointcal or fgcmcal output in this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't come up with the terminology, in this case, and it is confusing. This actually just means to recompute the "local" WCS and photoCalib values at the positions of the objects via a plugin, for processing that was done without that plugin.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is very unfortunate, because its the same name as the coadd/validate_drp options for using jointcal/fgcmcal.

Can you please pass it up the chain that these names are very confusing?

@@ -0,0 +1,278 @@
funcs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put a docstring at the top of this file describing what it is for?

Copy link
Collaborator

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but otherwise this looks good. I'll see about configuring jointcal to use it.

@erykoff erykoff merged commit 8acd773 into master Jun 4, 2020
@erykoff erykoff deleted the tickets/DM-24320 branch June 4, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants