DM-28756: Create VisitSummary tables for testdata_jointcal #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* HSC gen3 convert now assumes that the brightObjectMask exists, but we don't have it here, so we have to ignore it with `extraUmbrellaChildren = []`. * Add consolidateVisitSummary.py to the sourceTable script and export it during gen3 conversion.
parejkoj
force-pushed
the
tickets/DM-28756
branch
from
a673a57
to
6843e3c
Compare
erykoff
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Looks good, though I haven't tested the visitSummary themselves. Also, this won't pass with master fgcmcal, it needs lsst/fgcmcal@8c9a328 because this renames the refcat collection. I think it's easiest to put that commit on this ticket.
This update was made with the tickets/DM-28759 branch of pipe_tasks.
parejkoj
force-pushed
the
tickets/DM-28756
branch
from
6843e3c
to
8d78709
Compare
erykoff
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.