Review comments for DM-2418 ("afw tests reuse the same filenames") #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except OSError as e: | ||
| print "Warning: could not remove file %r: %s" % (outPath, e) | ||
| else: | ||
| print "Warning: could not find file %r" % (outPath,) |
There was a problem hiding this comment.
Should this be using logging rather than print? (That's a genuine question -- I don't know the answer, and I'm not aware of a standard -- so I ask for my information rather than as a correction.)
There was a problem hiding this comment.
I think print is better because this is intended for unit tests.
Logging would definitely be preferred if this was for pipeline execution.
I added context manager lsst.utils.tests.getTempFilePath to create temporary file paths based on unit test file path and name of the test function. This is intended to simplify unit tests and reduce the danger of tests using the same file name and thus colliding with each other (a serious problem in afw that has had 3 tickets and one incomplete fixup pass before this one). I removed temporaryFile, an older attempt that was only used in one place before my cleanup of afw unit tests and nowhere afterwards. I also added an overview documentation main.dox and improved the documentation of items in lsst.utils.tests. Add a main.dox file and fix a formatting error in a doc string Document p_lsstSwig.i and fix a few Doxygen errors I have not figured out how to get a live link to p_lsstSwig.i, but it doesn't include doxygen comments anyway. Clean up as per review and remove deprecated temporaryFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.