DM-32679: Call lsst.log traceSetAt from trace_set_at if available #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #108 +/- ##
==========================================
- Coverage 91.29% 91.27% -0.03%
==========================================
Files 36 36
Lines 2148 2154 +6
==========================================
+ Hits 1961 1966 +5
- Misses 187 188 +1
Continue to review full report at Codecov.
|
This allows people to enable TRACE loggers in C++ code without having to know that such loggers exist and without people defensively calling logUtils traceSetAt as well as trace_set_at.
timj
force-pushed
the
tickets/DM-32679
branch
from
9e9e3af
to
21ab723
Compare
This was referenced Nov 29, 2021
ktlim
approved these changes
Dec 1, 2021
|
Codecov can never see lsst.log so I don't have any choice in the coverage and mocking lsst.log didn't seem worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to enable TRACE loggers in C++ code without having to know that such loggers exist and without people defensively calling logUtils traceSetAt as well as trace_set_at.
Checklist
doc/changes