DM-33403: Move base.Packages to lsst.utils #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By iterating with sys.modules.iteritems(), we're subject to a race condition: if there's another thread (e.g., in scons) that does an import, sys.modules will change while we're iterating over it.
Modernized with futurize command. Currently uses pickle rather than attempting to use cPickle on legacy python.
Since we're reading from a set, the order of iteration isn't otherwise guaranteed. Different order means different version string and hence spurious failures.
Allows Packages to behave more like the dict that it contains.
This lets you bypass a file completely if using an object store.
This forces the unpickling to always use this class even if it was originally written as lsst.base.
The test was explicitly working around that function not existing but now it can be used.
timj
force-pushed
the
tickets/DM-33403
branch
from
d345cbb
to
70b0c00
Compare
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 91.28% 91.51% +0.23%
==========================================
Files 36 38 +2
Lines 2156 2417 +261
==========================================
+ Hits 1968 2212 +244
- Misses 188 205 +17
Continue to review full report at Codecov.
|
timj
commented
Jan 28, 2022
| We don't include any module for which we cannot determine a version. | ||
| """ | ||
| # Attempt to import libraries that only report their version in python | ||
| for module_name in PYTHON: |
There was a problem hiding this comment.
So this is why galsim always turns up in the version information even when we aren't using it.
This lets us test the conda package gathering and the eups.
This was referenced Jan 28, 2022
timj
commented
Jan 28, 2022
ktlim
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation can read old pickle files and force them to be frin the lsst.utils class.
Checklist
doc/changes