New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-33331: Monitor memory usage at select steps of BPS submission #112
Conversation
db4ce54
to
957e7ab
Compare
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 91.51% 91.86% +0.34%
==========================================
Files 38 40 +2
Lines 2417 2532 +115
==========================================
+ Hits 2212 2326 +114
- Misses 205 206 +1
Continue to review full report at Codecov.
|
957e7ab
to
14e8a07
Compare
Please fix the ticket number in the PR title. (While the branch appears correct, I think some tools rely on the title.) |
@ktlim Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of my comments are about reorganizing things as mentioned on the BPS review. I also think that the log output for time_this can be simplified.
One other thing that we might want to do is to remove the getrusage call out of logInfo
and move that into the new usage.py
. If you make it return a DataClass with all the entries that logPairs uses and then the get_peak_usage could either disappear or else call that and unpack the information from the DataClass.
a8a791b
to
b0b8ffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Some minor comments.
d9bc7da
to
cbabf2f
Compare
Moved functions related to measuring memory consumption in a separate module lsst.utils.usage.
cbabf2f
to
e453de1
Compare
Checklist
doc/changes