Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-33622: Add utility for forcing thread environment variables to set value #113

Merged
merged 4 commits into from Mar 10, 2022
Merged

DM-33622: Add utility for forcing thread environment variables to set value #113

merged 4 commits into from Mar 10, 2022

Conversation

timj
Copy link
Member

@timj timj commented Feb 17, 2022 •
edited

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited

Codecov Report

Merging #113 (74795bb) into main (d3710cf) will decrease coverage by 0.19%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   91.88%   91.69%   -0.20%     
==========================================
  Files          40       42       +2     
  Lines        2613     2661      +48     
==========================================
+ Hits         2401     2440      +39     
- Misses        212      221       +9
Impacted Files Coverage Δ
python/lsst/utils/threads.py 80.95% <80.95%> (ø)
tests/test_threads.py 81.48% <81.48%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3710cf...74795bb. Read the comment docs.

@timj timj mentioned this pull request Mar 7, 2022
Merged
2 tasks
@timj timj force-pushed the tickets/DM-33622 branch 2 times, most recently from 2e3b07b to 6f31116 Compare March 8, 2022 05:02
@timj timj requested review from andy-slac March 10, 2022 04:53
andy-slac
andy-slac approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

python/lsst/utils/threads.py Outdated Show resolved Hide resolved
python/lsst/utils/threads.py Outdated Show resolved Hide resolved
@timj timj merged commit 77c669a into main Mar 10, 2022
@timj timj deleted the tickets/DM-33622 branch March 10, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-slac andy-slac Awaiting requested review from andy-slac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @andy-slac