Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33919: Add helper class for periodic logging #116

Merged
merged 3 commits into from Mar 4, 2022
Merged

Conversation

timj
Copy link
Member

@timj timj commented Mar 3, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #116 (7472339) into main (4a0571d) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   91.88%   92.00%   +0.12%     
==========================================
  Files          40       40              
  Lines        2562     2602      +40     
==========================================
+ Hits         2354     2394      +40     
  Misses        208      208              
Impacted Files Coverage Δ
python/lsst/utils/packages.py 90.47% <ø> (ø)
python/lsst/utils/logging.py 84.03% <100.00%> (+2.48%) ⬆️
tests/test_logging.py 98.73% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0571d...7472339. Read the comment docs.

Copy link
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much nicer solution to log heartbeat messages!

tests/test_logging.py Outdated Show resolved Hide resolved
python/lsst/utils/logging.py Outdated Show resolved Hide resolved
python/lsst/utils/logging.py Show resolved Hide resolved
@timj timj merged commit 2b87d3b into main Mar 4, 2022
@timj timj deleted the tickets/DM-33919 branch March 4, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants