Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34386: Improve doImport error message. #122

Merged
merged 2 commits into from Apr 8, 2022
Merged

DM-34386: Improve doImport error message. #122

merged 2 commits into from Apr 8, 2022

Conversation

timj
Copy link
Member

@timj timj commented Apr 8, 2022

Rather than:

Unable to import "lsst.utils.version.__version__"

instead

Unable to import '"lsst.utils.version.__version__"' (No module named '"lsst')

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #122 (360c47f) into main (617c0b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 360c47f differs from pull request most recent head fc7f16e. Consider uploading reports for the commit fc7f16e to get more accurate results

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   91.70%   91.71%           
=======================================
  Files          42       42           
  Lines        2664     2667    +3     
=======================================
+ Hits         2443     2446    +3     
  Misses        221      221           
Impacted Files Coverage Δ
python/lsst/utils/doImport.py 95.00% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617c0b0...fc7f16e. Read the comment docs.

Copy link

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@timj timj merged commit 94d32e2 into main Apr 8, 2022
@timj timj deleted the tickets/DM-34386 branch April 8, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants