-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35697: Relocate profile context manager from pipe_base #131
Conversation
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 92.08% 92.24% +0.16%
==========================================
Files 42 42
Lines 2665 2709 +44
==========================================
+ Hits 2454 2499 +45
+ Misses 211 210 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on the python, even though I think this was just moved over from elsewhere.
"ping" commit should be "pin"?
# Nothing to do | ||
yield None | ||
return | ||
from cProfile import Profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to have this import at the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume @PaulPrice did not want to have the overhead of importing another python module that is very unlikely to be used.
Checklist
doc/changes