Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35697: Relocate profile context manager from pipe_base #131

Merged
merged 6 commits into from
Aug 10, 2022

Conversation

timj
Copy link
Member

@timj timj commented Aug 4, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #131 (ae8b77f) into main (e341ee4) will increase coverage by 0.16%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   92.08%   92.24%   +0.16%     
==========================================
  Files          42       42              
  Lines        2665     2709      +44     
==========================================
+ Hits         2454     2499      +45     
+ Misses        211      210       -1     
Impacted Files Coverage Δ
python/lsst/utils/timer.py 96.59% <94.11%> (-0.35%) ⬇️
tests/test_timer.py 99.52% <100.00%> (+0.03%) ⬆️
python/lsst/utils/introspection.py 100.00% <0.00%> (ø)
tests/test_getTempFilePath.py 97.80% <0.00%> (+0.02%) ⬆️
python/lsst/utils/packages.py 88.43% <0.00%> (+0.06%) ⬆️
python/lsst/utils/logging.py 84.67% <0.00%> (+0.12%) ⬆️
python/lsst/utils/iteration.py 96.96% <0.00%> (+0.19%) ⬆️
python/lsst/utils/usage.py 96.00% <0.00%> (+0.34%) ⬆️
tests/test_wrappers.py 98.85% <0.00%> (+0.57%) ⬆️
python/lsst/utils/threads.py 81.81% <0.00%> (+0.86%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the python, even though I think this was just moved over from elsewhere.

"ping" commit should be "pin"?

python/lsst/utils/timer.py Outdated Show resolved Hide resolved
python/lsst/utils/timer.py Outdated Show resolved Hide resolved
# Nothing to do
yield None
return
from cProfile import Profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to have this import at the top?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume @PaulPrice did not want to have the overhead of importing another python module that is very unlikely to be used.

tests/test_timer.py Show resolved Hide resolved
@timj timj merged commit e9fb255 into main Aug 10, 2022
@timj timj deleted the tickets/DM-35697 branch August 10, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants