New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-37808: Update pre-commit configuration #144
Conversation
Codecov ReportBase: 92.11% // Head: 92.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 92.11% 92.03% -0.08%
==========================================
Files 44 43 -1
Lines 2725 2688 -37
==========================================
- Hits 2510 2474 -36
+ Misses 215 214 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I enabled python 3.11 and it seems that something has changed in the logging hierarchy such that the stacklevel adjustment we use to make it report the callers file name and line number is off by one and is ending up reporting a line in unittest. Probably should fix that on another ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be updated to the absolute latest, which seems typical for @timj :)
There is a |
39992fb
to
5e0914e
Compare
Needed for the lsst.base.packages test
218bda7
to
6f56275
Compare
This tests the deprecated interface which is soon being removed. There is some interaction with the packages in python 3.9 causing get_caller_name to return the wrong answer when it is itself wrapped by @deprecated. This works fine in the non-deprecated version and on python 3.10 and 3.8 so it seems easiest to remove the test slightly ahead of schedule.
Checklist
doc/changes