Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37808: Update pre-commit configuration #144

Merged
merged 7 commits into from Feb 1, 2023
Merged

DM-37808: Update pre-commit configuration #144

merged 7 commits into from Feb 1, 2023

Conversation

timj
Copy link
Member

@timj timj commented Feb 1, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj requested a review from ktlim February 1, 2023 17:41
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 92.11% // Head: 92.03% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (c50acf1) compared to base (52aa68a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   92.11%   92.03%   -0.08%     
==========================================
  Files          44       43       -1     
  Lines        2725     2688      -37     
==========================================
- Hits         2510     2474      -36     
+ Misses        215      214       -1     
Impacted Files Coverage Δ
python/lsst/utils/ellipsis.py 71.42% <ø> (ø)
python/lsst/utils/tests.py 76.56% <ø> (ø)
tests/test_wrappers.py 98.85% <ø> (ø)
python/lsst/utils/get_caller_name.py 83.33% <0.00%> (-16.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj
Copy link
Member Author

timj commented Feb 1, 2023

I enabled python 3.11 and it seems that something has changed in the logging hierarchy such that the stacklevel adjustment we use to make it report the callers file name and line number is off by one and is ending up reporting a line in unittest. Probably should fix that on another ticket.

Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be updated to the absolute latest, which seems typical for @timj :)

@timj
Copy link
Member Author

timj commented Feb 1, 2023

the absolute latest

There is a pre-commit command for updating a configuration.

This tests the deprecated interface which is soon being removed.
There is some interaction with the packages in python 3.9 causing
get_caller_name to return the wrong answer when it is itself
wrapped by @deprecated. This works fine in the non-deprecated
version and on python 3.10 and 3.8 so it seems easiest to
remove the test slightly ahead of schedule.
@timj timj merged commit 0790857 into main Feb 1, 2023
@timj timj deleted the tickets/DM-37808 branch February 1, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants