DM-37987: Update to support python 3.11 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.38% // Head: 92.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 92.38% 92.42% +0.04%
==========================================
Files 41 41
Lines 2638 2654 +16
==========================================
+ Hits 2437 2453 +16
Misses 201 201
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ktlim
requested changes
Feb 21, 2023
timj
force-pushed
the
tickets/DM-37987
branch
from
7f37c6b
to
d252295
Compare
Python 3.11 no longer needs you to understand internal logging call stacks that are involved -- stacklevel=1 always now means the caller of the logging method.
Previously you could not ask for stacklevel=2 and expect your caller file to be used in the log message.
timj
force-pushed
the
tickets/DM-37987
branch
from
d252295
to
31a6521
Compare
ktlim
approved these changes
Feb 24, 2023
timj
force-pushed
the
tickets/DM-37987
branch
from
31a6521
to
35ab0a2
Compare
timj
force-pushed
the
tickets/DM-37987
branch
from
35ab0a2
to
350a165
Compare
Now only used in one place so can check the python version directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes