Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38062: Allow logging tests to pass even if pytest is changing the root log level #146

Merged
merged 2 commits into from Feb 21, 2023

Conversation

timj
Copy link
Member

@timj timj commented Feb 17, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 92.37% // Head: 92.38% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9ea1a54) compared to base (9926e89).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   92.37%   92.38%           
=======================================
  Files          41       41           
  Lines        2637     2638    +1     
=======================================
+ Hits         2436     2437    +1     
  Misses        201      201           
Impacted Files Coverage Δ
tests/test_logging.py 98.83% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj requested a review from ktlim February 21, 2023 15:34
@timj timj merged commit 097e31a into main Feb 21, 2023
@timj timj deleted the tickets/DM-38062 branch February 21, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants