DM-38665: No longer use assert for python version mismatch #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 93.64% 93.61% -0.04%
==========================================
Files 43 43
Lines 2692 2695 +3
==========================================
+ Hits 2521 2523 +2
- Misses 171 172 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ktlim
approved these changes
Apr 12, 2023
ktlim
reviewed
Apr 12, 2023
We can't actually guarantee that the ._version matches the parent version (it doesn't for pooch) so instead assume that the parent version is always right if there is a real mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't actually guarantee that the ._version matches the parent version (it doesn't for pooch) so instead assume that the parent version is always right if there is a real mismatch.
Checklist
doc/changes