DM-38812: Prefer using importlib.metadata rather than __version__ #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 93.79% 93.80%
=======================================
Files 43 43
Lines 2772 2775 +3
=======================================
+ Hits 2600 2603 +3
Misses 172 172
☔ View full report in Codecov by Sentry. |
ktlim
approved these changes
Apr 21, 2023
For example jsonschema has decided to no longer support __version__ and wants to use importlib.metadata. The downside of this is that importlib.metadata is much slower than asking for the __version__ of a module that's already imported. Hundreds of milliseconds vs microseconds to get the package versions and importlib.metadata does not seem to cache the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example jsonschema has decided to no longer support
__version__and wants to use importlib.metadata.The downside of this is that importlib.metadata is much slower than asking for the
__version__of a module that's already imported. Hundreds of milliseconds vs microseconds to get the package versions and importlib.metadata does not seem to cache the result.Checklist
doc/changes