DM-39785: Package modernization and ruff #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 93.94% 93.88% -0.07%
==========================================
Files 43 43
Lines 2826 2830 +4
==========================================
+ Hits 2655 2657 +2
- Misses 171 173 +2
☔ View full report in Codecov by Sentry. |
E402 triggers if `from __future__` is before the package docstring. Moving the package docstring above every import appeases ruff.
This makes it clear that we do not expect the variable to be used.
This was found by bugbear: B010: Do not call `setattr` with a constant attribute value. It is not any safer than normal property access.
This matches the flake8 and pydocstyle configuration that is already in use.
andy-slac
approved these changes
Jun 26, 2023
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: chartboost/ruff-action@v1 |
There was a problem hiding this comment.
Should we be adding a reusable workflow for ruff to rubin_workflows?
There was a problem hiding this comment.
Yes, although I don't think we can add it to the reusable linter workflow so we'd have to make a standalone workflow with those four lines in it. Maybe a shared linter could include ruff but not run it if a use_ruff parameter is false and then we can add a "use_ruff = True" argument to that. I'm happy to fix things up based on the RFC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes