Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40151: Fix bug in ImportTestCase #166

Merged
merged 11 commits into from Jul 24, 2023
Merged

DM-40151: Fix bug in ImportTestCase #166

merged 11 commits into from Jul 24, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jul 21, 2023

Also some other cleanups.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

timj added 8 commits July 21, 2023 10:48
Found by bugbear:

B023 Function definition does not bind loop variable `mod`
B010 [*] Do not call `setattr` with a constant attribute value. It is not any safer than normal property access.
This replaces

try:
    ...
except Exception:
    pass
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 91.30% and project coverage change: +0.03 🎉

Comparison is base (4b479e1) 93.97% compared to head (256fa23) 94.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   93.97%   94.00%   +0.03%     
==========================================
  Files          44       44              
  Lines        2870     2853      -17     
==========================================
- Hits         2697     2682      -15     
+ Misses        173      171       -2     
Impacted Files Coverage Δ
python/lsst/utils/tests.py 78.87% <60.00%> (+0.44%) ⬆️
python/lsst/utils/classes.py 100.00% <100.00%> (ø)
python/lsst/utils/packages.py 89.84% <100.00%> (-0.06%) ⬇️
python/lsst/utils/timer.py 99.23% <100.00%> (-0.04%) ⬇️
python/lsst/utils/wrappers.py 91.24% <100.00%> (-0.37%) ⬇️
tests/test_getTempFilePath.py 100.00% <100.00%> (ø)
tests/test_timer.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timj timj requested a review from mxk62 July 21, 2023 19:22
@timj timj merged commit d22af0e into main Jul 24, 2023
13 of 14 checks passed
@timj timj deleted the tickets/DM-40151 branch July 24, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants