Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-22287: Make inheritDoc more robust and add tests #171

Merged
merged 4 commits into from Sep 15, 2023
Merged

Conversation

timj
Copy link
Member

@timj timj commented Sep 14, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj force-pushed the tickets/DM-22287 branch 2 times, most recently from 76f40d4 to 6c9c271 Compare September 14, 2023 19:27
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 80.35% and project coverage change: -0.04% ⚠️

Comparison is base (f0e1c1a) 94.45% compared to head (447bd5e) 94.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   94.45%   94.41%   -0.04%     
==========================================
  Files          45       46       +1     
  Lines        3100     3154      +54     
==========================================
+ Hits         2928     2978      +50     
- Misses        172      176       +4     
Files Changed Coverage Δ
tests/test_classes.py 98.80% <ø> (ø)
tests/test_db_auth.py 100.00% <ø> (ø)
tests/test_decorators.py 100.00% <ø> (ø)
tests/test_deprecated.py 100.00% <ø> (ø)
tests/test_doImport.py 100.00% <ø> (ø)
tests/test_ellipsis.py 100.00% <ø> (ø)
tests/test_executables.py 100.00% <ø> (ø)
tests/test_getPackageDir.py 66.66% <ø> (ø)
tests/test_getTempFilePath.py 100.00% <ø> (ø)
tests/test_import.py 100.00% <ø> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of minor comments.

python/lsst/utils/inheritDoc.py Outdated Show resolved Hide resolved
python/lsst/utils/inheritDoc.py Outdated Show resolved Hide resolved
tests/test_inheritDoc.py Show resolved Hide resolved
@timj timj merged commit fba0d86 into main Sep 15, 2023
13 of 15 checks passed
@timj timj deleted the tickets/DM-22287 branch September 15, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants