New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-22287: Make inheritDoc more robust and add tests #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-22287
branch
2 times, most recently
from
September 14, 2023 19:27
76f40d4
to
6c9c271
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 94.45% 94.41% -0.04%
==========================================
Files 45 46 +1
Lines 3100 3154 +54
==========================================
+ Hits 2928 2978 +50
- Misses 172 176 +4
☔ View full report in Codecov by Sentry. |
timj
force-pushed
the
tickets/DM-22287
branch
from
September 14, 2023 20:19
514ec08
to
a812415
Compare
timj
force-pushed
the
tickets/DM-22287
branch
from
September 14, 2023 23:08
a812415
to
2a0ccc3
Compare
andy-slac
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of minor comments.
timj
force-pushed
the
tickets/DM-22287
branch
from
September 14, 2023 23:56
72bf1bf
to
3911d12
Compare
timj
force-pushed
the
tickets/DM-22287
branch
from
September 15, 2023 00:06
3911d12
to
447bd5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes