DM-40803: Change how conda list is run #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda.cli.python_api has been deprecated and the suggested replacement is intended solely for test code. Given that the original conda API was using subprocess to run conda list and not using any internal conda APIs, call conda list ourselves.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 94.41% 94.28% -0.14%
==========================================
Files 46 46
Lines 3154 3169 +15
==========================================
+ Hits 2978 2988 +10
- Misses 176 181 +5
☔ View full report in Codecov by Sentry. |
erykoff
reviewed
Sep 15, 2023
This has the advantage that no external process is needed.
timj
force-pushed
the
tickets/DM-40803
branch
from
ca932e5
to
85c8280
Compare
erykoff
approved these changes
Sep 15, 2023
timj
changed the title
timj
changed the title
At the moment this triggers the conda code path if set even if the tests themselves do not require conda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conda.cli.python_api has been deprecated and the suggested replacement is intended solely for test code. Given that the original conda API was using subprocess to run conda list and not using any internal conda APIs, call conda list ourselves.
Checklist
doc/changes