DM-42317: Make Singleton threadsafe #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 46 46
Lines 3206 3209 +3
=======================================
+ Hits 3013 3016 +3
Misses 193 193 ☔ View full report in Codecov by Sentry. |
Previously, if there were multiple threads concurrently calling a constructor for a Singleton class, you could end up instantiating more than one instance of the class. daf_butler classes using this metaclass are used in a multi-threaded context.
dhirving
force-pushed
the
tickets/DM-42317
branch
from
e20c983
to
63c0402
Compare
TallJimbo
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there were multiple threads concurrently calling a constructor for a Singleton class, you could end up instantiating more than one instance of the class. daf_butler classes using this metaclass are used in a multi-threaded context.
Checklist
doc/changes