Added equality helper and assert message for allClose #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -538,7 +538,8 @@ def plotImageDiff(lhs, rhs, bad=None, diff=None, plotFileName=None): | |||
|
|
|||
| @inTestCase | |||
| def assertClose(testCase, lhs, rhs, rtol=sys.float_info.epsilon, atol=sys.float_info.epsilon, relTo=None, | |||
| printFailures=True, plotOnFailure=False, plotFileName=None, invert=False): | |||
| printFailures=True, plotOnFailure=False, plotFileName=None, invert=False, | |||
| msg=None): | |||
There was a problem hiding this comment.
Formatting just looks a little weird; why not just add this to the previous line? (Obviously not a big deal.)
There was a problem hiding this comment.
I agree.
Also (existing issue) lhs and rhs are documented to be scalars or np arrays, but this code also works with other kinds of sequences of numbers. Please document that fact.
There was a problem hiding this comment.
I've reworked the formatting to be clear with the new name, and clarified the lhs/rhs docstrings.
parejkoj
force-pushed
the
tickets/DM-7267
branch
from
51b71e0
to
69675b6
Compare
|
|
||
|
|
||
| @inTestCase | ||
| def assertClose(*args, **kwargs): |
Cleaned up and expanded utils.tests tests and broke split those up into per-method tests.
parejkoj
force-pushed
the
tickets/DM-7267
branch
from
5a18e78
to
ef4d8b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.