DM-13046: Add random component to getTempFilePath filename #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents problems when the same test method names is used in different test case classes in the same file. It also allows you to use nested context managers.
PaulPrice
approved these changes
Dec 18, 2017
tests/test_getTempFilePath.py
Outdated
| class TestNameClash1(unittest.TestCase): | ||
| """The TestNameClashN classes are used to check that getTempFilePath | ||
| does not use the same name across different test classes in the same | ||
| file even if they have the same test methods.""" |
There was a problem hiding this comment.
Shouldn't this be a module-level docstring or comment, since it's about a group of classes?
Point out you're attempting to trigger a race condition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes getTempFilePath such that there is a little bit of randomness in the constructed name. This has two major benefits: