Update testing infrastructure for pytest #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Apr 27, 2016
timj
commented
- Add support for testing binaries.
- Reset leak counter after memory test runs.
- flake8 cleanups.
This is required to allow subsequent test files to be run in a clean leak environment and not be contaminated by previous failures. Particularly important if multiple test files are being run in the same process.
|
|
||
| test_function = cls._test_builder(root, binary) | ||
|
|
||
| This function does not attach the created test function to a class. |
There was a problem hiding this comment.
I don't understand and would appreciate rewording or more explanation. I can think of (at least) two possible meanings:
- The returned function is an unbound method of this class, so you must explicitly specify the "self" argument.
- The function is a free function.
There was a problem hiding this comment.
It returns a a free function that is expected to be bound to a class. This may really be an artifact of the way I developed it. I could remove this static method completely and do everything in discover_tests or I could make _test_builder a class method without returning anything.
timj
force-pushed
the
tickets/DM-5561
branch
4 times, most recently
from
1ca3e2b
to
747a1bc
Compare
* Print function * Absolute import * Modern exception catching. * in rather than has_key * open not file
productDir was replaced in commit d833a02
There are some remaining issues relating to pdb imports.
This is needed if we wish to test executable C++ binaries from a Python test runner.
Uses psutil. The test is skipped if psutil can not be imported.
* Add the setup_module call. * No longer use suite() system. * Add memory test as explicit class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.