Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test for NERSC password file #53

Merged
merged 1 commit into from Jun 19, 2018
Merged

Adjust test for NERSC password file #53

merged 1 commit into from Jun 19, 2018

Conversation

timj
Copy link
Member

@timj timj commented Jun 19, 2018

Now test for start and end of passwd file path.

@timj timj requested a review from PaulPrice June 19, 2018 20:53
Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but that's what I suggested so you can take that with a pinch of salt...
Can I suggest expanding the commit message to explain the reason behind the change (apparently the path for the file of interest can change).

Now test for start and end of passwd file path.

This is because it seems like the file can change location.
Recently the file moved from /var/lib/sss/mc/passwd to
/var/lib/sss/mcpath/passwd. We now test for a path starting
with /var/lib and ending with passwd.

This is a more generic version of 6579449
@timj timj merged commit 958ce35 into master Jun 19, 2018
@ktlim ktlim deleted the tickets/DM-14841 branch August 25, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants