DM-15599: Stop using boost persistence in afw #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
changed the title
r-owen
changed the title
TallJimbo
requested changes
Sep 10, 2018
python/lsst/utils/wrappers.py
Outdated
| @@ -377,6 +377,8 @@ def register(self, key, subclass): | |||
| isStatic = isinstance(obj, staticmethod) | |||
| if isBuiltin or isStatic: | |||
| if hasattr(self, name): | |||
| if name != "__init__subclass__": | |||
| continue | |||
There was a problem hiding this comment.
I'd like to avoid this special-casing if we can. Can you say anything more about the conditions under which it was needed?
There was a problem hiding this comment.
I moved it to the if name in "__new__": test, and that does appear to be a new method we can expect on objects. Please have another look.
from wrappers.py
in TemplateMeta.register. The old message did not provide enough values to `format`, resulting in a strange and irrelevant error. While I was at it I tried to make the message clearer and more informative.
r-owen
force-pushed
the
tickets/DM-15599
branch
2 times, most recently
from
0dc0ffd
to
e43f680
Compare
TallJimbo
approved these changes
Sep 11, 2018
in TemplateMeta.register. The problem only showed up for MaskX because that was the only subclass registered with non-None `TEMPLATE_DEFAULTS`
r-owen
force-pushed
the
tickets/DM-15599
branch
from
e43f680
to
28adf19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why this change was required.