DM-15809: Replace boost::regex with std::regex #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-15809
branch
from
e176e3d
to
121b09c
Compare
ktlim
reviewed
Sep 22, 2018
include/lsst/utils/RaDecStr.h
Outdated
|
|
||
| #ifndef RA_DEC_STR_H | ||
| #define RA_DEC_STR_H | ||
|
|
||
| #include <string> | ||
| #include <cmath> | ||
| #include <regex> |
There was a problem hiding this comment.
Um, doesn't look like this is even needed in this header file. It should move to the .cc file, no?
src/RaDecStr.cc
Outdated
| @@ -184,8 +184,8 @@ double sexagesimalStrToDecimal( | |||
|
|
|||
| //Search for leading - sign. | |||
| std::string pmStr = "^-"; | |||
| static const boost::regex pm(pmStr); | |||
| if(boost::regex_search(inStr, pm)) | |||
| static const std::regex pm(pmStr); | |||
There was a problem hiding this comment.
This seems a bit excessive for checking the first character.
src/RaDecStr.cc
Outdated
| //This throws an exception of failure. I could catch it, | ||
| //but I'd only throw it again | ||
| if(! boost::regex_search(inStr.c_str(), what, re)) { | ||
| if(! std::regex_search(inStr.c_str(), what, re)) { | ||
| std::string msg= boost::str(boost::format( | ||
| "Failed to parse %s as a right ascension or declination with regex %s") | ||
| % inStr % regexStr); |
There was a problem hiding this comment.
Below, I believe std::cmatch supports what[1].str() to simplify the conversions.
|
#62 is going to supersede this PR to a certain extent. I'll revisit it once the radec stuff has been removed. |
timj
force-pushed
the
tickets/DM-15809
branch
from
121b09c
to
ccc10e5
Compare
|
@ktlim I've redone this ticket now that the original raDecStr.cc code has been removed. Not sure if you want a second look since all the code you previously commented on has gone now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.