Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-16650: Add nJy<->magnitude C++ converter #66

Merged
merged 1 commit into from Dec 27, 2018
Merged

Conversation

parejkoj
Copy link
Contributor

No python bindings: astropy does this very well already.

No python bindings because astropy handles this directly.

Lifted out of afw PhotoCalib.
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though as I commented on the afw PR, it's a shame the recommended way of doing this in python is buried in a c++ header.

@parejkoj parejkoj merged commit f0259e2 into master Dec 27, 2018
@timj timj deleted the tickets/DM-16650 branch January 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants