Skip NFS files in fd leak test and fix grammar in failure message #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,13 +125,14 @@ def testFileDescriptorLeaks(self): | |||
| now_open = _get_open_files() | |||
|
|
|||
| # Some files are opened out of the control of the stack. | |||
| now_open = set(f for f in now_open if not f.endswith(".car")) | |||
| now_open = set(f for f in now_open | |||
| if not f.endswith(".car") and ".nfs" not in f) | |||
There was a problem hiding this comment.
I thought .nfs files were left behind when a process has a file open on a network filesystem and that file is removed (unlinked) from its directory. These files are supposed to be cleaned up after the file is closed. If so, doesn't the presence of a .nfs file attached to an open file descriptor indicate that there really is an open file that shouldn't be?
There was a problem hiding this comment.
Over the years I've had weirdness relating to NFS that relate to issues where it takes a relatively large amount of time for NFS resources to get freed. Given that the tests all work fine on local disk without any file leakage I am inclined to put this down to NFS race conditions and keep the code in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.