Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27638: Try to ensure that previous module not found error is included #91

Merged
merged 1 commit into from
Nov 20, 2020
Merged

DM-27638: Try to ensure that previous module not found error is included #91

merged 1 commit into from
Nov 20, 2020

Commits on Nov 19, 2020

  1. Try to ensure that previous module not found error is included 

    Since doImport treats ModuleNotFoundError as a special error
indicating that it should probably retry with a different
subset of the supplied string, this means that failures
to import dependencies trigger a confusing error report.
It's hard to disentangle real errors from dependencies
versus a request for a class within a module, so as a short
term fix include the previous import error in the final
error. Hopefully this will mitigate the problem.

Also add some explicit tests for this scenario.
    @timj
    timj committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    fd816d6 View commit details
    Browse the repository at this point in the history