DM-31046: Add mime.cache to file leaks ignore list #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself looks fine; since I'm not familiar with PIL, I can't comment on whether there's a way to avoid using the cache or ensure it's promptly closed. |
PIL loads the mime.cache when checking file types, and may not release it, causing a spurious test failure.
parejkoj
force-pushed
the
tickets/DM-31046
branch
from
20cf545
to
2d19cbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 24 24
Lines 1420 1420
=======================================
Hits 1258 1258
Misses 162 162
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding code to analysis_ap that uses PIL to open PNG images, which can leave the
mime.cacheopen. We don't have control over that, so just ignore file leak failures due to this.