Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-17409: Change Metadata class to use dict interface for keys, values, items #104

Merged
merged 2 commits into from Aug 24, 2022
Merged

DM-17409: Change Metadata class to use dict interface for keys, values, items #104

merged 2 commits into from Aug 24, 2022

Conversation

timj
Copy link
Member

@timj timj commented Aug 23, 2022 •
edited

{Summary of changes. Prefix PR title with ticket handle.}

  • Passes Jenkins CI.
  • Documentation is up-to-date.

Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME

kfindeisen
kfindeisen approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. A couple of comments on the docstrings, which apply to all three methods.

python/lsst/verify/jobmetadata.py Outdated Show resolved Hide resolved
python/lsst/verify/jobmetadata.py Outdated Show resolved Hide resolved
@timj
Change Metadata keys/items/values to match dict interface
c6f079d 
Return KeysView, ItemsView, and ValuesView types.
@timj timj merged commit 394c473 into main Aug 24, 2022
@timj timj deleted the tickets/DM-17409 branch August 24, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @kfindeisen