DM-34340: Adapt to daf_butler API changes. #118
Conversation
tests/test_extract_metricvalues.py
Outdated
| @@ -125,7 +125,7 @@ def check_stdout(kind, n, last_line, contained, **kwargs): | |||
| self.assertIn(contained, result) | |||
|
|
|||
| # default call with no kwargs | |||
| contained = "{instrument: 'TestCam', detector: 25, visit: 54321, ...}" | |||
| contained = "{instrument: 'TestCam', detector: 25, visit: 54321, band: '447', physical_filter: '346'}" | |||
There was a problem hiding this comment.
I think printing just the "basic" dimensions was actually a useful feature (though I don't know @parejkoj's thoughts on this). Is there no way to do that with the new system?
There was a problem hiding this comment.
Happy to switch it back, though the "..." will disappear. Since it was hard to print the non-required values if and only if they were present before (but that's easy now), I've been converting stringifications that had the "..." (indicating that available values were not being printed) to print all available values. But it doesn't have to be that way.
There was a problem hiding this comment.
I don't have a strong opinion on this, though having shorter dataIds can keep output from being too cluttered with keys that are irrelevant for a given use (but irrelevancy is often in the eye of the beholder).
There was a problem hiding this comment.
I have restored this stringification tested here to the concise version (now spelled str(data_id.required)), so the only change to the test is now dropping the , ... from the expected string.
TallJimbo
force-pushed
the
tickets/DM-34340
branch
from
f439471
to
8bc33a6
Compare
TallJimbo
force-pushed
the
tickets/DM-34340
branch
from
8bc33a6
to
3f4f533
Compare
{Summary of changes. Prefix PR title with ticket handle.}
Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME