Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-16822: Use pipe.base.*DatasetConfig in MetricTask configs #32

Merged
merged 3 commits into from Jan 9, 2019
Merged

DM-16822: Use pipe.base.*DatasetConfig in MetricTask configs #32

merged 3 commits into from Jan 9, 2019

Conversation

kfindeisen
Copy link
Member

This PR modifies the Gen 2 class compatibility.MetricTask to use InputDatasetConfig to specify its inputs. This change will simplify the transition to the Gen 3 MetricTask, once it exists. I'm not sure if the documentation makes it clear enough that InputDatasetConfig is the primary way for MetricTask to describe its inputs.

While the original ticket also asked to use OutputDatasetConfig, this can't be done until Butler support for Measurement is available.

@kfindeisen
Fix typos.
868ec55
@kfindeisen
Make compatibility.MetricTask depend on InputDatasetConfig.
3c9e773 
This change will reduce the amount of config-writing needed to migrate
individual tasks from verify.compatibility.MetricTask to verify.MetricTask,
as well as make it more practical to write an adapter between the
two interfaces.
@kfindeisen kfindeisen requested a review from czwa January 7, 2019 23:18
@kfindeisen kfindeisen mentioned this pull request Jan 7, 2019
Merged
@kfindeisen
Update copyright.
cdba6c5 
UW made changes in 2018, and just now made changes in 2019.
czwa
czwa approved these changes Jan 9, 2019
View reviewed changes
Copy link

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only note is a generic warning that the pipelineTask code is not yet finalized, so there might be additional issues when this is converted to a full pipelineTask.

@kfindeisen kfindeisen merged commit cdba6c5 into master Jan 9, 2019
@kfindeisen kfindeisen deleted the tickets/DM-16822 branch January 9, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czwa czwa czwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kfindeisen @czwa