DM-18906: Use safe YAML loading in verify #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using yaml.load with a generic loader is discouraged, as it allows code injection attacks. All calls have been rewritten to use safe_load or CSafeLoader.
timj
approved these changes
Jun 8, 2019
| @@ -80,7 +80,8 @@ def load_all_ordered_yaml(stream, **kwargs): | |||
| return yaml.load_all(stream, OrderedLoader) | |||
|
|
|||
|
|
|||
| def _build_ordered_loader(Loader=yaml.Loader, object_pairs_hook=OrderedDict): | |||
| def _build_ordered_loader(Loader=yaml.CSafeLoader, | |||
| object_pairs_hook=OrderedDict): | |||
There was a problem hiding this comment.
It's possible that this ordered dict code is no longer needed since python3.7 guarantees dicts are ordered. The main problem with yaml is that on write it forces key sort (which can be disabled with sort_keys=False)
There was a problem hiding this comment.
Could be. I'm not sure how to check that a rewrite wouldn't have ill effects, and I agree that it's out of scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all
YAMLLoadWarnings from buildingverify. I also manually searched foryaml.loadcalls that are not exercised by the unit tests, but didn't find any.