Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-22093: Store begin/end times of ap_pipe in ap_verify #59

Merged
merged 2 commits into from Nov 20, 2019

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Nov 18, 2019

This PR adds a string completion timestamp to the metadata for all timing measurements. There are no test or documentation changes, as measurement metadata are provided "as-is" with no requirements on their availability or format.

Example output from inspect_jobs.py:

Measurements:
                      ap_pipe.ApPipeTime =  94.2989 s ({'estimator': 'pipe.base.timeMethod', 'end': '2019-11-16T00:12:02.754711'})
               pipe_tasks.ProcessCcdTime =   24.629 s ({'estimator': 'pipe.base.timeMethod', 'end': '2019-11-16T00:10:41.117107'})
                          ip_isr.IsrTime =   5.3994 s ({'estimator': 'pipe.base.timeMethod', 'end': '2019-11-16T00:10:20.938137'})
        pipe_tasks.CharacterizeImageTime =  10.0975 s ({'estimator': 'pipe.base.timeMethod', 'end': '2019-11-16T00:10:31.614739'})

Copy link

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple and good enough for me. Thanks.

@kfindeisen kfindeisen merged commit 2cd8923 into master Nov 20, 2019
@kfindeisen kfindeisen deleted the tickets/DM-22093 branch November 20, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants