DM-21910: Move lsst.verify.gen2tasks.MetricTask to lsst.verify.tasks #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Nov 19, 2019
timj
reviewed
Nov 19, 2019
I can't have any sort of alias from gen2tasks to tasks.MetricTask without causing a circular import.
kfindeisen
force-pushed
the
tickets/DM-21910
branch
from
746cbaf
to
f4768be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
gen2tasks.MetricTasktotasks.MetricTask, while keeping an alias ingen2tasksfor backward-compatibility. It also modifies all otherverifycode to refer to the newMetricTask.tasks.MetricTaskwill be migrated to Gen 3 on DM-21911, using the procedures previously developed for migratingCmdLineTask.