DM-21912: Implement PpdbMetricTask.runQuantum #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Dec 16, 2019
| import lsst.utils.tests | ||
| from lsst.pex.config import Config | ||
| from lsst.daf.butler import Quantum | ||
| from lsst.pipe.base import Task, Struct |
There was a problem hiding this comment.
A really minor point, but you could alphabetize these imports.
There was a problem hiding this comment.
The imports are in dependency order, which, while not required, is a convention across much of the LSST code.
kfindeisen
force-pushed
the
tickets/DM-21912
branch
from
656c29f
to
f66fb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets
ApdbMetricTaskpass its output data ID fromrunQuantumtorun, allowing fine-grained database metrics in Gen 3.For clarity, the first commit is a direct copy of
MetricTask.runQuantum, which has some nonstandard processing. I can't change the call torunwithout duplicating the rest of the code. 馃槥