DM-23426: Use PipelineTask test framework for MetricTask #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test functions replace code previously in tests/butler_utils.py.
The test functions replace code previously in tests/butler_utils.py.
The daf.butler.tests and pipe.base.testUtils libraries provide the same functionality.
Validation is not included in generic MetricTask tests both because run may be an expensive method (it isn't for these MetricTasks) and because validation needs good coverage of the possible task configs to be meaningful.
morriscb
approved these changes
Apr 1, 2020
|
Maybe not "should" yet -- I'm still figuring out the best way to do things myself. For example, using the See the daf_butler and pipe_base documentation for this code, and note that I want to change the call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all
MetricTasktests that previously used the custom code intests/butler_utils.pyto use the new PipelineTask test framework, and expands existing tests. I do not have a direct test ofMetricTask.runQuantum, because of the difficulties of meaningfully testing the abstractMetricTask.