DM-21919: Run ap_verify end-to-end in Gen 3 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field was already deprecated; letting it stay required means forcing users to either fail validation or get a deprecation warning.
natelust
approved these changes
Aug 10, 2020
The same class (and any subclasses) can now be used for metadata from any source task, provided they only need to process one metadata object at a time.
kfindeisen
force-pushed
the
tickets/DM-21919
branch
from
b640128
to
4816a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs in
MetadataMetricTaskthat were discovered while developingap_verify, and makes the task's dimensions configurable to support metadata from a variety of science pipeline tasks.