Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-28958: Allow the butler tools to sanitize file names #78

Merged
merged 1 commit into from Feb 25, 2021

Conversation

SimonKrughoff
Copy link
Contributor

@SimonKrughoff SimonKrughoff commented Feb 25, 2021

The key used for the job dictionary was allowed to use unsafe characters for a filename. Use butler utilities to sanitize the key so it is safe to use as the filename to write to disk.


  • Passes Jenkins CI.
  • Documentation is up-to-date.

Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I do think we want to keep the sort from the old code; otherwise just style comments.

python/lsst/verify/bin/jobReporter.py Outdated Show resolved Hide resolved
python/lsst/verify/bin/jobReporter.py Outdated Show resolved Hide resolved
python/lsst/verify/bin/jobReporter.py Outdated Show resolved Hide resolved
@SimonKrughoff SimonKrughoff merged commit d90f2a7 into master Feb 25, 2021
@SimonKrughoff SimonKrughoff deleted the tickets/DM-28958 branch February 25, 2021 21:43
@@ -112,8 +120,7 @@ def run(self):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the line above but you do not need to create a list from the return value of queryDatasets if you are immediately going to loop over it. It's an iterator itself so the list is overhead you don't want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants