[DM-31131] lsst.verify outputs non-standard NaN in JSON #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Resolve quantity | ||
| # Resolve quantity, represent None values as np.nan | ||
| if value is None: | ||
| value = np.nan |
There was a problem hiding this comment.
This means that values that were inf originally will be mapped to np.nan going forward. I guess there is nothing we can really do about that.
afausti
force-pushed
the
tickets/DM-31131
branch
from
531e017
to
47cdedb
Compare
|
Running against Jenkins CI again, should be good. |
|
It passed Jenkins CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Represent metric values that are
np.nan(ornp.inf) inverifyasnullwhen serializing a job to a JSON document. When deserializing a JSON document a metric values that isnullis explicitly converted tonp.nan.