Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-33220: Change Task metadata storage class to TaskMetadata #95

Merged
merged 2 commits into from Jan 12, 2022
Merged

DM-33220: Change Task metadata storage class to TaskMetadata #95

merged 2 commits into from Jan 12, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jan 12, 2022 •
edited by kfindeisen

This is now the standard storage class for task metadata.

{Summary of changes. Prefix PR title with ticket handle.}

  • Passes Jenkins CI.
  • Documentation is up-to-date.

Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME

@timj
Change Task metadata storage class to TaskMetadata
db5f39f 
This is now the standard storage class for task metadata.
kfindeisen
kfindeisen reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize we have a deadline of this evening, but would it be possible to propagate this change to the documentation? I know that at least the docstrings in the same file still refer to metadata as being a PropertySet.

@timj
Copy link
Member Author

timj commented Jan 12, 2022

Yes. Sorry. Didn't realize.

@kfindeisen
Copy link
Member

A search reveals only three files that mention PropertySet, this file and two related test files. I'd suggest replacing all references; it should be safe.

@timj
Copy link
Member Author

timj commented Jan 12, 2022

Done. Tests pass locally.

kfindeisen
kfindeisen approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the changes!

@timj timj merged commit 17962e7 into main Jan 12, 2022
@timj timj deleted the tickets/DM-33220 branch January 12, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @kfindeisen