DM-25450: Add Rowe statistics to SQuaSH #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Aug 30, 2020
arunkannawadi
force-pushed
the
tickets/DM-25450
branch
from
8f26cac
to
2fc0187
Compare
laurenam
reviewed
Sep 1, 2020
|
|
||
| --- | ||
| # Specification partial | ||
| id: "RhoStat_smallScale-base" |
There was a problem hiding this comment.
I was looking for consistency as well. If all can be referred to (here and in the metric names and definitions) as rhoStat, then use that everywhere. If you feel that the abbreviation is not appropriate, the they should all be rhoStatistics. A mix-n-match is just confusing.
There was a problem hiding this comment.
Agreed. I use rhoStatistics in full everywhere in this file.
arunkannawadi
changed the title
arunkannawadi
force-pushed
the
tickets/DM-25450
branch
from
2fc0187
to
193f686
Compare
laurenam
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines new metrics related to Rho Statistics computed from star catalogs in
lsst-dm/pipe_analysis. There is an associated PR which includes the code for measurement of these metrics.