Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26456: Create sky object performance metric trackers #25

Merged
merged 1 commit into from Sep 24, 2020

Conversation

leeskelvin
Copy link
Contributor

No description provided.

@leeskelvin leeskelvin force-pushed the tickets/DM-26456 branch 2 times, most recently from 406824b to 9880e53 Compare August 31, 2020 18:40
tags:
- skyObject
- skyLevel
- skyMean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of skyObject, skyLevel and skyMean really useful here (and below, skyMean in the Std definition)?

And, again, I think it may be a better idea to leave the specific flux algorithm from the name and you could indicate in the description that the particular flux measurement algorithm is included in the metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reduced the tags to just - skyObject and - skyLevel for both the sky object mean and standard deviation metric measures.

(PS - Following conversations we've had over the prior couple of weeks and the issues surrounding shortening these metric names, I've left the metric names as-is for now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PPS: As a small update for the sake of accuracy, I've updated the two description strings to mention the fact that these are statistical values based on sigma-clipped data, i.e.:

The mean value of the sigma-clipped sky object base_CircularApertureFlux_9_0_instFlux data.
The standard deviation of the sigma-clipped sky object base_CircularApertureFlux_9_0_instFlux data.

@leeskelvin leeskelvin force-pushed the tickets/DM-26456 branch 4 times, most recently from 8105ef2 to 5c9fb04 Compare September 21, 2020 14:55
@leeskelvin leeskelvin merged commit b1000a3 into master Sep 24, 2020
@leeskelvin leeskelvin deleted the tickets/DM-26456 branch September 24, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants