DM-26593: Create an integrated pipeline for AP fake analysis #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add quotes around metric unit.
morriscb
force-pushed
the
tickets/DM-26593
branch
from
9da0182
to
407c09b
Compare
kfindeisen
approved these changes
Dec 28, 2020
metrics/ap_pipe.yaml
Outdated
Comment on lines
33
to
40
| ApFakesCompletenessMag22t24: | ||
| description: Completeness of recovered fakes in the magnitudes range 22-24. | ||
| unit: '%' | ||
| tags: | ||
| - ap_verify | ||
| - task | ||
| - monitoring | ||
|
|
There was a problem hiding this comment.
Since all these metrics have identical units and tags, I'd recommend using &/<< to reduce the boilerplate. You can find an example in pipe_tasks.yaml.
metrics/ap_pipe.yaml
Outdated
Comment on lines
26
to
27
| description: Completeness of recovered fakes in the magnitudes range 20-22. | ||
| unit: '%' |
There was a problem hiding this comment.
Is this metric defined in any document or something? If so, consider providing a reference entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.