Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency Check for Convergence and Magnification #68

Closed
evevkovacs opened this issue Jan 29, 2018 · 2 comments
Closed

Consistency Check for Convergence and Magnification #68

evevkovacs opened this issue Jan 29, 2018 · 2 comments

Comments

@evevkovacs
Copy link
Contributor

evevkovacs commented Jan 29, 2018

Since these are related, we should check that the shears, convergence and magnification are self consistent (within machine precision). The test is that magnification should be satisfy
'1/magnification = (1-kappa)2 - shear12 - shear2**2)'
(kappa = convergence)

@rmandelb
Copy link

@evevkovacs - totally minor/irrelevant point but for people new to GitHub, I wanted to point out that you can use quote marks to avoid your math getting reinterpreted as GitHub markdown:
1/magnification = [(1-kappa)**2 - shear_1**2 - shear_2**2]
And for reference to papers, magnification is often denoted mu, just as shear is often denoted gamma.

yymao added a commit that referenced this issue Jan 29, 2018
@yymao yymao self-assigned this Jan 29, 2018
@yymao
Copy link
Member

yymao commented Jan 29, 2018

implemented in #66

@yymao yymao closed this as completed in 5862fc7 Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants