Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Make "Additional Emails" feature optional #147

Closed
abias opened this issue Jul 11, 2014 · 5 comments
Closed

Make "Additional Emails" feature optional #147

abias opened this issue Jul 11, 2014 · 5 comments

Comments

@abias
Copy link

abias commented Jul 11, 2014

Hi,

in Quickmail, there is the new feature "Additional Emails". As an admin, I would like to disable this feature with a setting because we don't want users to send emails to others than our Moodle users.

Thanks,
Alex
@elliott2081
Copy link
Contributor

That's a good idea, and should be easy to do. Look for it in the next release.
Thanks!

@abias
Copy link
Author

abias commented Aug 28, 2014

Hi elliott,
could you please tell me when approximately the next release will arrive?
Thanks, Alex

@elliott2081
Copy link
Contributor

I would guess around late october / november. I may try to add the setting sooner than that though. If I do I will message you.

@Kathrin84 Kathrin84 mentioned this issue Jun 1, 2015
Closed
elliott2081 added a commit that referenced this issue Jul 7, 2015
@elliott2081
Merge pull request #184 from Kathrin84/Fix-to-issue-#147-addional-adm…
17d6d36 
…in-setting

Fix to #147
timb28 added a commit to HarcourtsAcademy/quickmail that referenced this issue Jan 20, 2016
@timb28
Merge branch 'MOODLE_STABLE_30' of https://github.com/lsuits/quickmail …
c728b85 
…into HA-Moodle30

# By David Elliott (8) and others
# Via David Elliott (7) and Robert Russo (1)
* 'MOODLE_STABLE_30' of https://github.com/lsuits/quickmail:
  Updated version for upgrades
  fixed typo that was messing up restore functionality
  Version stuffs for Moodle 3.x
  getting rid of jasons generator code, can still be found in that specific repo
  deleted unnecessary jquery file
  fixed spacing issue if the user has a signature selected.
  Made changes to email.php that should finally fix the plain text formatting issues, to just standard moodle way of handling plain text formats
  small comment change
  Fix to lsuits#147
  Fix to issue lsuits#153
  Migrating add_to_log call for Quickmail lsuits#180
  trying out a better way of formatting, using moodle functions, instead of just strip_tags
  include jquery correctly
  just adding some tags
  Moved icons into content->items and leave content->icons empty. So that it is consistent with the pattern of all the other blocks.
  Removing outdated lang files
@rlorenzo
Copy link
Contributor

We just discovered this new setting and were shocked to see that the default is set to No. That changed the current behavior that is expected for the user. Shouldn't the default be to Yes to keep current existing behavior and anyone who wanted it changed would set it to No?

@elliott2081
Copy link
Contributor

I think it's set to yes, as a way of encouraging people to use it and noticing the new feature. I think there's probably a good argument either way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlorenzo @elliott2081 @abias